Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent description of push behavior #734

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Fix inconsistent description of push behavior #734

merged 1 commit into from
Jul 20, 2021

Conversation

kimsin98
Copy link

Fix parts that #482 did not address for #481.

@Aksoo
Fix inconsistent description of push behavior
c927329 
Git push defaults to current branch (simple).
@welcome
Copy link

welcome bot commented Jul 20, 2021

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Wohoo! 🎉 Thanks for opening your first pull request to the DataLad Handbook! 😎 We really appreciate your time and effort to contribute to the project - you're amazing! 👏

adswa
adswa approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Thanks a lot for catching this!

@adswa
Copy link
Contributor

adswa commented Jul 20, 2021

hey @all-contributors please add @Aksoo for bug, content

@allcontributors allcontributors bot mentioned this pull request Jul 20, 2021
Merged
@allcontributors
Copy link
Contributor

@adswa

I've put up a pull request to add @Aksoo! 🎉

@adswa adswa merged commit 78ddfb7 into datalad-handbook:master Jul 20, 2021
@welcome
Copy link

welcome bot commented Jul 20, 2021

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@adswa
Copy link
Contributor

adswa commented Jul 20, 2021

@Aksoo Please feel free to add yourself to the zenodo.json file, or leave your preferred name, affiliation, and/or orcid and I'll add you to it. We're building the author list from this file :)

@kimsin98 kimsin98 deleted the patch-1 branch July 20, 2021 09:05
@kimsin98
Copy link
Author 

{
  "affiliation": "Korea Advanced Institute of Science and Technology, Daejeon, Korea",
  "name": "Kim, Sin",
  "orcid": "0000-0003-4652-3758"
}

@adswa
Copy link
Contributor

adswa commented Jul 20, 2021

Thx! Added in 71afdfe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adswa adswa adswa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimsin98 @adswa @Aksoo